fix(canvas/a11y): aria-hidden on decorative SVGs + MissingKeysModal semantics - #1594
Merged
Merged
Conversation
…al semantics
- DeleteCascadeConfirmDialog: aria-hidden on warning triangle SVG (button
already has adjacent text content; icon is purely decorative)
- Toolbar: aria-hidden on 4 decorative SVGs (stop-all, restart-pending,
search, help) — buttons all have aria-label/aria-expanded/text
- MissingKeysModal: role="dialog" aria-modal="true" aria-labelledby on
container, id="missing-keys-title" on heading, requestAnimationFrame
focus management via useRef (replaces autoFocus={index===0})
- CreateWorkspaceDialog: remove redundant aria-describedby={undefined}
WCAG 2.1 SC 1.1.1 — screen readers skip purely-presentational icons.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
Contributor
Author
|
Core-QA Review ✅ — Clean a11y fix. aria-hidden on decorative SVGs is correct (buttons already have aria-label or adjacent text). MissingKeysModal gets proper dialog semantics (role=dialog, aria-modal, focus management via useRef). Removal of aria-describedby={undefined} is a net improvement. +23/-11, small scope. Approved for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
aria-hidden="true"to purely decorative SVG icons and improves MissingKeysModal accessibility:aria-hiddenon 4 decorative SVGs — stop-all (button has aria-label), restart-pending (aria-label), search (visible text + kbd shortcut), help (aria-expanded + text)role="dialog",aria-modal="true",aria-labelledbyon container;id="missing-keys-title"on heading;requestAnimationFramefocus management viauseRef(replacesautoFocus={index===0})aria-describedby={undefined}Test plan
WCAG 2.1 SC 1.1.1
Adding
aria-hidden="true"is the correct pattern for purely decorative inline SVGs — screen readers skip the icon and users hear the adjacent accessible label instead.Extracted from PR #1550 (which was bloated by force-updated staging history). Clean, focused commit.